Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musl: fix test/js/bun/http/serve.test.ts #15271

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

musl: fix test/js/bun/http/serve.test.ts #15271

wants to merge 27 commits into from

Conversation

nektro
Copy link
Member

@nektro nektro commented Nov 20, 2024

fixes assertion below

❯ bun-debug --print 'const fs = require'
ASSERTION FAILED: !(attributes & PropertyAttribute::CustomAccessorOrValue)
src/bun.js/WebKit/Source/JavaScriptCore/runtime/PropertyDescriptor.cpp(180) : void JSC::PropertyDescriptor::setAccessorDescriptor(unsigned int)
1   0x109f18194 JSC::PropertyDescriptor::setPropertySlot(JSC::JSGlobalObject*, JSC::PropertyName, JSC::PropertySlot const&)
2   0x109de1458 JSC::JSObject::getOwnPropertyDescriptor(JSC::JSGlobalObject*, JSC::PropertyName, JSC::PropertyDescriptor&)
3   0x109f1484c JSC::ProgramExecutable::initializeGlobalProperties(JSC::VM&, JSC::JSGlobalObject*, JSC::JSScope*)
4   0x1098fd994 JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*)
5   0x109bf72cc JSC::evaluate(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
6   0x10470af7c Bun::evaluateCommonJSModuleOnce(JSC::VM&, Zig::GlobalObject*, Bun::JSCommonJSModule*, JSC::JSString*, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
7   0x1047238d8 Bun::createCommonJSModule(Zig::GlobalObject*, JSC::JSValue, ResolvedSource&, bool)::$_0::operator()(JSC::JSGlobalObject*, JSC::Identifier const&, WTF::Vector<JSC::Identifier, 4ul, WTF::CrashOnOverflow, 16ul, WTF::VectorBufferMalloc>&, JSC::MarkedVector<JSC::JSValue, 8ul, WTF::RecordOverflow>&) const
8   0x1047234a8 WTF::Detail::CallableWrapper<Bun::createCommonJSModule(Zig::GlobalObject*, JSC::JSValue, ResolvedSource&, bool)::$_0, void, JSC::JSGlobalObject*, JSC::Identifier, WTF::Vector<JSC::Identifier, 4ul, WTF::CrashOnOverflow, 16ul, WTF::VectorBufferMalloc>&, JSC::MarkedVector<JSC::JSValue, 8ul, WTF::RecordOverflow>&>::call(JSC::JSGlobalObject*, JSC::Identifier, WTF::Vector<JSC::Identifier, 4ul, WTF::CrashOnOverflow, 16ul, WTF::VectorBufferMalloc>&, JSC::MarkedVector<JSC::JSValue, 8ul, WTF::RecordOverflow>&)
9   0x109dc4454 JSC::moduleLoaderParseModule(JSC::JSGlobalObject*, JSC::CallFrame*)
10  0x11180421c 9   ???                                 0x000000011180421c 0x0 + 4588585500
11  0x10aabcde8 llint_entry
12  0x10aabcde8 llint_entry
13  0x10aabcde8 llint_entry
14  0x10aabcde8 llint_entry
15  0x10aa946b8 vmEntryToJavaScript
16  0x1098ff5a0 JSC::Interpreter::executeCallImpl(JSC::VM&, JSC::JSObject*, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&)
17  0x109dc1770 JSC::runJSMicrotask(JSC::JSGlobalObject*, WTF::ObjectIdentifierGeneric<JSC::MicrotaskIdentifierType, WTF::ObjectIdentifierThreadSafeAccessTraits<unsigned long long>, unsigned long long>, JSC::JSValue, JSC::JSValue, JSC::JSValue, JSC::JSValue, JSC::JSValue)
18  0x10a01fb84 JSC::VM::drainMicrotasks()
19  0x10496055c Zig::GlobalObject::drainMicrotasks()
20  0x1049605a8 JSC__JSGlobalObject__drainMicrotasks
21  0x105fc75b0 src.bun.js.event_loop.EventLoop.drainMicrotasksWithGlobal
22  0x105b293a8 src.bun.js.event_loop.EventLoop.tick
23  0x105ddb128 src.bun.js.event_loop.EventLoop.waitForPromise
24  0x1058571ac src.bun.js.javascript.VirtualMachine.waitForPromise
25  0x1064bdb74 src.bun.js.javascript.VirtualMachine.loadEntryPoint
26  0x105dcda98 src.bun_js.Run.start
27  0x105824c30 src.bun.js.javascript.OpaqueWrap__anon_69101__struct_101132.callback
28  0x104a15a84 JSC__VM__holdAPILock
29  0x1053a27b0 src.bun.js.bindings.bindings.VM.holdAPILock
30  0x10575c5e0 src.bun_js.Run.boot
31  0x105770b98 src.cli.Command.start

fixes fd limit on rc ci targets

Closes #15188
Closes #15184

@robobun
Copy link

robobun commented Nov 20, 2024

@nektro, your commit 2bb2dfe has 18 failures in #6764:

  • test/js/node/test/parallel/worker-nested-uncaught.test.js - segmentation fault on 🐧 3.20 x64-baseline
  • test/js/bun/http/bun-serve-static.test.ts - timeout on 🐧 3.20 x64
  • test/regression/issue/09041.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/bun/spawn/spawn.test.ts - 1 failing on 🐧 22.04 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/deno/performance/performance.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/web/fetch/fetch.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/web/fetch/fetch-preconnect.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/node/watch/fs.watch.test.ts - 2 failing on 🍎 14 aarch64
  • test/js/web/fetch/fetch.tls.test.ts - 1 failing on 🍎 13 aarch64
  • test/js/bun/http/serve.test.ts - 1 failing on 🍎 13 aarch64
  • test/js/bun/http/serve.test.ts - 1 failing on 🍎 14 x64
  • test/cli/run/require-cache.test.ts - 1 failing on 🪟 2019 x64
  • test/js/node/fs/fs.test.ts - 2 failing on 🪟 2019 x64
  • test/cli/hot/hot.test.ts - 2 failing on 🪟 2019 x64-baseline
  • test/cli/hot/hot.test.ts - timeout on 🐧 3.20 aarch64
  • test/cli/hot/hot.test.ts - timeout on 🐧 3.20 x64-baseline
  • @nektro nektro changed the title Update fs-watch-recursive-linux-parallel-remove.test.js fix fs-watch-recursive-linux-parallel-remove.test.js Nov 21, 2024
    @nektro nektro changed the title fix fs-watch-recursive-linux-parallel-remove.test.js fix test/js/bun/http/serve.test.ts Nov 23, 2024
    @nektro nektro changed the title fix test/js/bun/http/serve.test.ts musl: fix test/js/bun/http/serve.test.ts Nov 23, 2024
    @nektro nektro marked this pull request as ready for review November 23, 2024 02:07
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants