Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS-398-fix-record-launch #399

Merged
merged 1 commit into from
Nov 13, 2024
Merged

ROS-398-fix-record-launch #399

merged 1 commit into from
Nov 13, 2024

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Nov 13, 2024 •
edited
Loading

Related Issues & PRs

Summary of Changes

  • Fix a typo in record.launch and other parameters

Validation

  • Call record.launch and verify it successfully captures the bag file from the sensor.
  • Replay the generated bag file using replay.launch

@Samahu Samahu added the bug Something isn't working label Nov 13, 2024
@Samahu Samahu self-assigned this Nov 13, 2024
@Samahu Samahu merged commit 1dbdbb4 into master Nov 13, 2024
1 check passed
@Samahu Samahu deleted the ROS-398-fix-record-launch branch November 13, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twslankard twslankard Awaiting requested review from twslankard

@celentes celentes Awaiting requested review from celentes

@chrisbayruns chrisbayruns Awaiting requested review from chrisbayruns

@akatumalla-ouster akatumalla-ouster Awaiting requested review from akatumalla-ouster

@matthew-lidar matthew-lidar Awaiting requested review from matthew-lidar

@diego-guridi diego-guridi Awaiting requested review from diego-guridi

Assignees

@Samahu Samahu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typo in record.launch
1 participant
@Samahu