Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Frame ID for Image Messages #394

Open
SwiftGust opened this issue Nov 4, 2024 · 0 comments
Open

Wrong Frame ID for Image Messages #394

SwiftGust opened this issue Nov 4, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@SwiftGust
Copy link

SwiftGust commented Nov 4, 2024

IMPORTANT
Before reporting a new bug make sure you have:

Describe the bug

I think current frame_id set for image processor in ros driver is incorrect,
it should be lidar_frame not pointcloud_frame
where pointcloud processor can transform lidar_frame to sensor_frame after conversion from polar to cartesian frame
However, I don't think image frame cannot be transformed directly in polar coordinate and cannot find such transformation in the code too.
So I think frame_ids for image processors should be in lidar_frame or project image would create some subtle misalignment

if (impl::check_token(tokens, "IMG")) {
processors.push_back(ImageProcessor::create(
info, tf_bcast.point_cloud_frame_id(),

To Reproduce
Steps to reproduce the behavior (steps below are just an example):

  1. Install & build ouster_ros
  2. Run ouster ros driver nodelet with image enabled - nothing needs to be changed
  3. Inspect image header(rostopic echo /ouster/range_image/header or else)
rostopic echo /ouster/range_image/header
seq: 6122
stamp: 
  secs: 1730362404
  nsecs: 340280549
frame_id: "os_sensor"
---

Platform (please complete the following information):

  • Ouster Sensor? OS0 tested but applicable to all
  • Ouster Firmware Version? 2.5.3
  • ROS version/distro? noetic
  • Operating System? Linux Ubuntu 20.04
  • Machine Architecture? Tested on x64
@SwiftGust SwiftGust added the bug Something isn't working label Nov 4, 2024
@Samahu Samahu self-assigned this Nov 4, 2024
@SwiftGust SwiftGust changed the title Wrong Frame IDs for Image Messages Wrong Frame ID for Image Messages Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants