Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a laser_scan_frame #235

Open
lowellausen opened this issue Oct 16, 2023 · 0 comments
Open

Add a laser_scan_frame #235

lowellausen opened this issue Oct 16, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@lowellausen
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Previously the scan and point cloud had the same orientation when setting the point cloud frame as the value of the sensor frame. After the previous change (#195), they are off by 180 degrees regardless of which frame you set as the point cloud frame.

Lidar frame as the point cloud frame:

laser_data

Sensor frame as the point cloud frame:

laser_sensor

Describe the solution you'd like
A clear and concise description of what you want to happen.

Adding a separate laser_scan_frame parameter, so we can have by default the current behavior, where the scan data will be stamped with lidar frame. But it also gives us the possibility to stamp it with the sensor frame (as we do for the point cloud) and they keep being aligned.

I'm also opening a PR with this change, to be evaluated!

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Of course, also adding the transformation into the given frame would be ideal.

Targeted Platform (please complete the following information only if applicable, otherwise dot N/A):

  • Ouster Sensor? N/A
  • Ouster Firmware Version? N/A
  • ROS version/distro? Humble
  • Operating System? N/A
  • Machine Architecture? N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants