Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent values not been generated #85

Open
claucece opened this issue Oct 2, 2018 · 6 comments
Open

Persistent values not been generated #85

claucece opened this issue Oct 2, 2018 · 6 comments
Assignees
Labels
architecture bug importance medium An issue that is medium level importance. It's good to have but not 100% necessary.

Comments

@claucece
Copy link
Member

claucece commented Oct 2, 2018

The persistent values are not generated or published in this case:

  • Bob does not have the otr-ng plugin active
  • Bob logs in in his account
  • Bob activates the otr-ng plugin
@claucece claucece added bug importance medium An issue that is medium level importance. It's good to have but not 100% necessary. architecture discuss labels Oct 2, 2018
@olabini
Copy link
Contributor

olabini commented Oct 2, 2018

Ah, yes. I think that's because the signed-on event is used to generate values, but since the sign-on happens before the plugin is active, no such event ever happens. We have two reasonable alternatives here:

  • Check for already active accounts when the plugin is enabled, and init them manually
  • Wait until the ensure_-mechanism is ready. This will make sure to create the needed values before they are needed to use, no matter if it's at sign-on or at some other time.

@claucece
Copy link
Member Author

claucece commented Oct 2, 2018

Mmmm:

Wait until the ensure_-mechanism is ready. This will make sure to create the needed values before they are needed to use, no matter if it's at sign-on or at some other time.

Yeah, let's see.

@olabini
Copy link
Contributor

olabini commented Oct 6, 2018

This issue can now be picked up to fix.

@claucece
Copy link
Member Author

claucece commented Oct 7, 2018

Thanks @olabini

@olabini
Copy link
Contributor

olabini commented Jan 30, 2019

If you feel like checking if this still happen, that would be great. I think it should be fine now.

@olabini
Copy link
Contributor

olabini commented Mar 10, 2019

I'll take a look and see.

@olabini olabini self-assigned this Mar 10, 2019
@olabini olabini removed the discuss label Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture bug importance medium An issue that is medium level importance. It's good to have but not 100% necessary.
Projects
None yet
Development

No branches or pull requests

2 participants