Account not found

[claucece]

Sometimes when the UI actions are too fast (you log in and not wait for the publication, and immediately start an OTR conversation), the account is not found and this happens:

No prekey client.

The printing of the account gives:

THE ACCOUNTz??? `

Sometimes as well, the protocol and account are not found for writing the persistent files and this gets writen:

@<b2><8a><dd><ce>!?:(null)
AAAABAABG4LpCAACABCzsG9HGCbEqD5hSHddu76Mu8Ol9NKhqAkXJyMoTVHFjLczxxcfaqUVRxknERlZK9VLwxlqLLVfoAAABAAAAAMzNAAABQAAAABbpUkLfLmvgcxJ16sRJYAOKWlpIgtLXpBEbFdi/YLAayijC269LAQXpEP23U4YPZdBky9CXDRRNeSwXkmA2SPnbokGoA4xhCiMsQRIoe6jQsxFblCC8vef+sGtzUrYWQC9fPlyIWucTz10QN5usCZhv3kchTUA

Can it be a threading error?

[claucece]

cc. @olabini

[olabini]

I'll look into this. Did you add any debug-printing to see those statements?

[claucece]

No, I just printed the account->username on several places to see if it was been found.

[olabini]

Any idea where the specific places were printed that you saw?

[claucece]

Yes, immediately as you send the storage status message, and you get back that they are too low, and you try to publish:

https://github.com/otrv4/pidgin-otrng/blob/master/prekey-plugin.c#L98

Then this func does not get a prekey client:

https://github.com/otrv4/pidgin-otrng/blob/master/prekey-plugin.c#L274

And it fails here:

https://github.com/otrv4/pidgin-otrng/blob/master/prekey-plugin.c#L85

Around being incorrectly written in the persistent file, Idk when it happen, it just popped out.

[olabini]

I have not been able to reproduce this - I've added a large amount of printings all over the place to check for it, but it never happens for me...

[claucece]

@olabini I'll recheck this.. maybe it is something solved.

[claucece]

I haven't seen this happening again but as we have some other weird bugs; it is worth keeping it open.

[olabini]

I just got a crash here:

                #4  0x00007fdd49b12654 get_domain_from_jid (pidgin-otrng.so)
                #5  0x00007fdd49b11c17 otrng_plugin_get_prekey_client (pidgin-otrng.so)

My guess is that this is from a missing PurpleAccount, so probably connected.

[olabini]

I've added some assertions to the pidgin-helpers file, to make sure all these invariants are always checked.

[claucece]

I'm quite uncomfortable on all of this refactorings, as it seems like a lot of functionality is getting broken. I'm unsure in which other places it is broken...

[olabini]

Sorry, not sure what you're talking about on this issue. I just added assertions to make it faster to see when something is broken.

[claucece]

Well, I'm talking in general. But let's talk about this on the call.

[olabini]

Have you seen this issue again?

[olabini]

OK, we haven't seen this issue for a long while. I'll close this issue now. In case it comes back we can reopen, but I don't think it will.