Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check full backwards compatibility with libotr #32

Open
3 tasks
yakiradixon opened this issue Jul 26, 2017 · 4 comments
Open
3 tasks

Check full backwards compatibility with libotr #32

yakiradixon opened this issue Jul 26, 2017 · 4 comments
Labels
API architecture importance high An issue that is absolutely necessary to have done before final release
Milestone
architecture

Comments

@yakiradixon
Copy link

yakiradixon commented Jul 26, 2017 •
edited by claucece
Loading

Why

The library should be backwards compatible with libotr.

References

See otrv4/otrv4#48

Tasks

  • Check what is missing from libotr to be "fully" compatible.
  • Check that all callbacks are working.
  • Check that everything from the bottom list is covered.

Open questions

None.
@claucece claucece changed the title Backwards compatibility with libotr Check full backwards compatibility with libotr Nov 11, 2017
@claucece claucece added this to the Working prototype milestone Nov 18, 2017
@claucece claucece self-assigned this Dec 13, 2017
@claucece
Copy link
Member

claucece commented Dec 14, 2017 •
edited
Loading

To check:

  • Meta instance tags
  • Fragmentation
  • Context
  • Resend messages by time: lastsent,lastrec
  • OTR offer
  • Check OtrlSessionIdHalf for ssid
  • Old mac keys on context_priv
  • Other error codes from otrv3
  • Logged in
  • Disconnect all instances
  • otrl_message_poll_get_default_interval
  • privkey.h
  • tlv.h
  • version.h and m4
  • possibly: What about policies to be used by plugins? #14
  • priv, fingerprints from libotr3

claucece added a commit that referenced this issue Dec 14, 2017
@claucece
Add error to query message #32
2b34fd1
claucece added a commit that referenced this issue Dec 14, 2017
@claucece
Define ssid bold section #32
7fcfb29
claucece added a commit that referenced this issue Dec 19, 2017
@claucece
Take policy from query msg #32 & #14
689de75
@claucece
Copy link
Member

claucece commented Feb 2, 2018

Also check:

  • fingerprint_seen_otr3 seems a bit shortsighted. maybe we should just give a "version" argument to fingerprint_seen instead?
  • Implement or check most of the otrv4_client_callbacks_ functions

@claucece claucece removed their assignment Mar 18, 2018
@olabini
Copy link
Contributor

olabini commented Apr 9, 2018

When it says backwards compatible, it doesn't actually mean backwards compatible - it means all the functionality should still work and be available, but not with the same API.

@claucece claucece removed this from the Working prototype milestone Apr 10, 2018
@juniorz juniorz mentioned this issue Jun 19, 2018
Closed
@claucece claucece added API importance high An issue that is absolutely necessary to have done before final release and removed OTRv4 basics waiting labels Jun 26, 2018
@juniorz juniorz mentioned this issue Jul 9, 2018
Closed
1 task
@olabini olabini self-assigned this Sep 22, 2018
@olabini olabini removed their assignment Sep 22, 2018
@olabini
Copy link
Contributor

olabini commented Mar 9, 2019

After discussion about this, most of this is probably done - although we need to make sure the otr3 callbacks work correctly.

@claucece claucece added this to the architecture milestone Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API architecture importance high An issue that is absolutely necessary to have done before final release
Projects
None yet
Milestone
architecture
Development

No branches or pull requests
3 participants
@olabini @yakiradixon @claucece