-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
article: guide to integrate mobile money payment in a web app #34
base: main
Are you sure you want to change the base?
article: guide to integrate mobile money payment in a web app #34
Conversation
acea103
to
51e2ba8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice article, would be great to include direct payment (without using the Notch pay web UI), as this method can be done from the server and could be important for the business to maintain the user on the web page and have a unique brand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice article overall
I'm not sure if it's possible with Notchpay, but you're right ! |
It is in fact possible. Check out Direct charge here |
Cool ! thanks for the link. Hmmm i will not update the article actually, i will do it later in a new article or update the existing one |
My PR is still open guys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I will let @RMPR review in deep
51e2ba8
to
0877766
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR, in addition to what I have commented on. A generic comment that applies to the whole article. I don't have strong feelings about whether to use "i" or "I", however, mixing up the two is a bit confusing for the reader. For example:
an article I wrote in January
The in the next sentence
i'm explaining
Can you please convert all the "i" to capital case?
|
||
## Initiating payment | ||
|
||
The [documentation](https://developer.notchpay.co/) already describe all the endpoints you can use, particularly in the [API reference](https://developer.notchpay.co/api/tag/payment) section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The [documentation](https://developer.notchpay.co/) already describe all the endpoints you can use, particularly in the [API reference](https://developer.notchpay.co/api/tag/payment) section. | |
The [documentation](https://developer.notchpay.co/) already describes all the endpoints you can use, particularly in the [API reference](https://developer.notchpay.co/api/tag/payment) section. |
|
||
The [documentation](https://developer.notchpay.co/) already describe all the endpoints you can use, particularly in the [API reference](https://developer.notchpay.co/api/tag/payment) section. | ||
|
||
In our case, we will use [Flask](https://pypi.org/project/Flask/) to build the controllers and the [Requests](https://pypi.org/project/requests/) library to make requests to Notchpay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to explain a bit why Flask is chosen.
|
||
If you have any questions, don't hesitate to ask in the OSS Telegram Channel. | ||
|
||
Ciao ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ciao ! |
We do hope to have you back :)
No description provided.