Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ToricSchemes] Fix underlying_divisor for trivial toric divisor #3962

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

HereAround
Copy link
Member

No description provided.

@lgoettgens lgoettgens added topic: toric schemes experimental Only changes experimental parts of the code labels Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.09%. Comparing base (a096328) to head (ec5dcfe).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3962   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files         593      593           
  Lines       81743    81743           
=======================================
  Hits        68743    68743           
  Misses      13000    13000           
Files Coverage Δ
...perimental/Schemes/src/ToricDivisors/attributes.jl 84.21% <100.00%> (ø)

Copy link
Collaborator

@HechtiDerLachs HechtiDerLachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been done according to our joint discussion and I approve. Thank you!

@joschmitt joschmitt merged commit ed82b76 into oscar-system:master Jul 24, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code topic: toric schemes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants