change the handling of IncludeJuliaStartupFile (for Julia 1.10)
#1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Julia 1.10, the startup file seems to be not readable with `include` during precompilation, and the old code runs into an error.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1017 +/- ##
==========================================
+ Coverage 75.69% 76.03% +0.34%
==========================================
Files 51 51
Lines 4205 4165 -40
==========================================
- Hits 3183 3167 -16
+ Misses 1022 998 -24
|
|
We just discussed this PR this morning, and I proposed the following: we drop |
remove the GAP user preference `IncludeJuliaStartupFile`, do not try to include the Julia startup file from GAP, instead use an environment variable in the situation that GAP gets started via `gap.sh`.
|
Two tests with Julia nightly failed, I restarted them, then only one test failed ... |
|
Julia nightly breakage is "normal", there were changes there and we'll probably have to rebuild a bunch of JLLs. So don't worry about it. |
fingolfin
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JuliaInterface package introduces a GAP user preference
IncludeJuliaStartupFilethat is intended to force loading Julia's startup file in the situation that GAP gets started from Julia via a gap.sh script.The file
pkg/JuliaInterface/init.gcontains code that evaluates this user preferences and if necessary loads this file into the Julia session.All this should be irrelevant if one first starts Julia and then loads GAP, because then the Julia startup file has been read already, but this is not true:
If one calls
using Oscarin a fresh Julia session and ifOscar.jlhas to get precompiled then the precompilation takes place in a Julia that has not read its startup file.In Julia before 1.10, then JuliaInterface simply includes this startup file. In Julia 1.10, including this file fails (and then one gets a crash).
The current proposal is not yet good enough.
An info message is printed during precompilation, saying that the startup file could not be included. We can simply omit this message. However, I fear that the above analysis is not yet good enough, so perhaps we need another change.