typelib_cxx_loader under ubuntu 16.04

[Kynneb]

When doing a fresh install without prior knowledge it is a bit difficult to track down the issue of enabling the castxml loader manually in the init.rb although it is a neccessary step under 16.04 (no gccxml which is used per default).

Would it be possible to set the variable according to the choice made in https://github.com/orocos-toolchain/autoproj/blob/master/orocos.osdeps where there distinction between 16.04 and earlier versions of ubuntu in respect to the cxx_loader is already made?

[doudou]

This is actually already done in rock-core .... it should have been done here.

I could review a PR that moves the rock-core package set code here, but I can't do it myself within the next month or two.

[Kynneb]

Replacing

cxx_loader = Autoproj.config.get 'typelib_cxx_loader', 'gccxml'

with

if Autoproj.config.has_value_for?('typelib_cxx_loader')
  cxx_loader = Autoproj.config.get 'typelib_cxx_loader'
elsif Autoproj.workspace.os_package_resolver.has?('castxml')
  cxx_loader = 'castxml'
else 
  cxx_loader = 'gccxml'
end

did the job for me.

I am not sure about opening a PR, though as I am pretty new to the whole topic and not sure if I got those things right.

[doudou]

This is the gist of it, but will also start using castxml on systems that were previously using gccxml. It would in addition not allow to override the choice (the orocos-toolchain users like their flexibility ...)

[Kynneb]

Please excuse my lack of knowledge, but would you mind to explain?

In my tests it behaved quite as expected - using the conf variable when set in autoproj/init.rb or orocos.toolchain/init.rb (otherwise on a fresh install there would be no value for typelib_cxx_loader) and else only using castxml when the value was set according to the orocos.osdeps (i.e. only on ubuntu versions 16.04 and later and debian systems where the value is set by default)

Also there were no problems "overriding" the castxml option once set by setting clang or gccxml in one of the init.rb files

[doudou]

Please excuse my lack of knowledge, but would you mind to explain?

I read too fast and did not realize that you were indeed the right thing.

I can't apply it as-is because I think it could compete (and break) the castxml selection in rock.core. I'll try to take some time to try it out in the next few days. I'm extremely busy right now, so ping back with a friendly reminder in a week or so if you haven't heard back from me ;-)

[Kynneb]

That sounds great. Thank you in advance 👍

[Kynneb]

friendly ping :-)

[doudou]

Gulp no time ... sorry.

[doudou]

Hey. Could you try #28 ?