NewLines normalization before or after custom scrubbers?

[JanKrivanek]

I'm trying to see if this was intention or not.

Currently the new lines normalization is being done after the custom scrubbers are invoked:

Verify/src/Verify/Serialization/Scrubbers/ApplyScrubbers.cs

Line 139 in f5af3cd

target.FixNewlines();

It used to be applied before:

Verify/src/Verify/Verifier/InnerVerifier_Inner.cs

Line 68 in a2540cb

builder.FixNewlines();

We made our code less dependent on this behavior (which is good idea anyways) - so I'm just being curious.

[SimonCropp]

i think it is reasonable that newlines are normalized after scrubbers. but i cant seem to reproduce the problem

i added some more tests 312e237

[JanKrivanek]

Makes sense.
It is good as it is now - and makes more sense now (applying builtin scrubbers after the custom ones)

It was just an issues in our legacy code that was using custom scrubber that expected the newlines to be already normlized - and hence it got broken by this change. This is fixed on our side already.