Autonomous Empirical Research Initiative
Contributing to packages from others in the group #373
-
|
When contributing to our packages (especially), the ones where we are not the main author, should we adapt the workflow for autora? Create an issue → Create a branch → Push the changes → Create a pull request |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 4 replies
-
|
Are you referring to the "contribution repo" or the sub-packages? |
Beta Was this translation helpful? Give feedback.
-
|
For example, I changed the urls in the autora-core package that John is working on, instead of directly just commiting and pushing it might be better if we do the full issue->branch->pull request thing. So John can see what I have changed and if he approves. |
Beta Was this translation helpful? Give feedback.
-
|
Let's do that. We should report the workflow in the Readme though... |
Beta Was this translation helpful? Give feedback.
-
|
I'm not so sure we need such a long chain. I think the key bit is just to create a pull request, everything else is sort of implied. We can just link here in our overall contribution guide: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests# |
Beta Was this translation helpful? Give feedback.
-
|
... and make sure that all the repositories are suitably protected to avoid accidental non-PR changes. |
Beta Was this translation helpful? Give feedback.
I'm not so sure we need such a long chain. I think the key bit is just to create a pull request, everything else is sort of implied. We can just link here in our overall contribution guide: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests#