Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delay!(x,0.9) deletes the last half of x #48

Closed
Darf-Ferrara opened this issue Oct 30, 2024 · 4 comments
Closed

delay!(x,0.9) deletes the last half of x #48

Darf-Ferrara opened this issue Oct 30, 2024 · 4 comments
Assignees

Comments

@Darf-Ferrara
Copy link

julia> x = signal([1.,2,3,4,5,6,7],3)
julia> delay!(x,.99999999999)
SampledSignal @ 3.0 Hz, 7-element Vector{Float64}:
 9.821130612501859e-12
 1.0000000000063198
 2.0000000000155396
 3.000000000002601
 0.0
 0.0
 0.0

It seems that any delay! less than 1.0 will erase half the signal.

@mchitre mchitre self-assigned this Nov 1, 2024
@mattcbro
Copy link

mattcbro commented Nov 6, 2024

I can verify this bug is happening. In Julia Version 1.11.1 and SignalAnalysis v0.9.1 on linux Mint 21.3 Cinnamon. The last half of the signal get's zero'd out. It makes this important tool unusable sad to say.

@mchitre
Copy link
Member

mchitre commented Nov 6, 2024

Taking a look at it. Seems to happen for some fractional delays.

mchitre added a commit that referenced this issue Nov 6, 2024
@mchitre
Copy link
Member

mchitre commented Nov 6, 2024

Fixed in 8a4ee16. Patch release 0.9.2 should be available shortly.

@mchitre mchitre closed this as completed Nov 6, 2024
@Darf-Ferrara
Copy link
Author

Thanks for the quick update. This is a great package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants