Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real baseband data should be treated as complex #37

Closed
mchitre opened this issue Jun 29, 2023 · 1 comment · Fixed by #40
Closed

Real baseband data should be treated as complex #37

mchitre opened this issue Jun 29, 2023 · 1 comment · Fixed by #40
Assignees
Labels
bug Something isn't working

Comments

@mchitre
Copy link
Member

mchitre commented Jun 29, 2023

Example:

s = rand([-1,1], 10)
upconvert(s, ...)

fails (silently gives wrong result), but

s = complex.(rand([-1,1], 10), 0)
upconvert(s, ...)

works

@mchitre mchitre added the bug Something isn't working label Jun 29, 2023
@mchitre mchitre self-assigned this Jun 29, 2023
@mchitre
Copy link
Member Author

mchitre commented Aug 8, 2023

The problem is that a real input to upconvert() is treated as a passband signal and converted to analytic by removing the negative frequency component. This destroys the signal.

Since upconvert() expects a baseband signal, we should assume that a real signal is a baseband signal with 0 as imaginary component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant