Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display mnemonic on ord wallet create even if import descriptors times out #4091

Open
casey opened this issue Nov 20, 2024 · 0 comments
Open

Comments

@casey
Copy link
Collaborator

casey commented Nov 20, 2024

Reported by @gmart7t2 here:

@raphjaph it used to be that if there was a timeout while rescanning, the seed phrase wouldn't be displayed (I'm think more about "wallet create" I guess). Is that still the case?

In case this isn't clear:

When I create a new ord wallet, ord imports new descriptors, bitcoind rescans the last 2 hours of blocks, which might cause an RPC timeout, which aborts the ord command and prevents the JSON result (which contains the new seed phrase) from being displayed.

If bitcoind times out, the descriptors can be imported, but we'll never have printed out the mnemonic. We should fix this somehow. I think we should print the same output to standard out, but also return an error code and print an error message to stderr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant