Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for promises in README #15

Open
orangemug opened this issue Oct 28, 2016 · 2 comments
Open

Add support for promises in README #15

orangemug opened this issue Oct 28, 2016 · 2 comments
Labels
enhancement

Comments

@orangemug
Copy link
Owner

Uncaught promises should cause failure, for example if data isn't "foo" then the following should fail

getSomething()
  .then(function(data) {
    assert.equal(data, "foo")
  });
@orangemug
Copy link
Owner Author

@oliverbrooks does this look correct? I have a working branch that I'll push up shortly.

@orangemug
Copy link
Owner Author

Working branch feature/promise...feature/markdown-promise-support (branched from PR #14)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orangemug