Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vector skin and its dark/night mode #2086

Open
Lucent opened this issue Sep 13, 2024 · 1 comment
Open

Support Vector skin and its dark/night mode #2086

Lucent opened this issue Sep 13, 2024 · 1 comment

Comments

@Lucent
Copy link

Lucent commented Sep 13, 2024

Currently Wikipedia defaults to using the the new Vector 2022 theme which supports light and dark mode via toggling a single class on <html>, skin-theme-clientpref-night. You can see this class inserted even in current mwoffliner dumps, probably by header JS, but it has no effect, perhaps due to pulling CSS for the Minerva skin.

Will the new Vector skin eventually be supported or is there some way of forcing mwoffliner to pull Vector skin themed pages? This would make light/dark theming trivial and solve all related bugs.

I will sponsor a bounty of your choosing to get this done.

@Jaifroid
Copy link
Collaborator

It would be great to have a theme module that would apply different CSS according to the user's choice, including the dark-themed variants. There were some initial ideas towards this in #596 and #1240, but the idea got stuck. Failing a proper theming system, I'd agree that supporting the latest Vector skin would be a minimum, especially if it comes with, essentially, a "free" dark theme that has all the complications ironed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants