Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed OVC logger. #27837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed OVC logger. #27837

wants to merge 1 commit into from
+9 −4

Conversation

popovaan
Copy link
Contributor

Details:

  • Fix OVC to not override logger if verbose is turned on.

Tickets:

@popovaan popovaan requested a review from a team as a code owner November 29, 2024 17:05
@github-actions github-actions bot added the category: OVC OVC tool label Nov 29, 2024
@popovaan popovaan requested a review from mvafin November 29, 2024 17:09
rkazants
rkazants reviewed Nov 30, 2024
View reviewed changes
tools/ovc/openvino/tools/ovc/logger.py
def init_logger(lvl: str, verbose: bool):
def init_logger(lvl: str, verbose: bool, python_api_used: bool):
if verbose and python_api_used:
# We need to not override logger in case of verbose=True to allow user set a log level
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can user set logger level? In help, there is no info about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkazants rkazants rkazants approved these changes

@mvafin mvafin mvafin approved these changes

Assignees
No one assigned
Labels
category: OVC OVC tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@popovaan @mvafin @rkazants