Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug in F1AdaptiveThreshold which occurs only when there are no anomalous images in a validation set #2437

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tanemaki
Copy link
Contributor

📝 Description

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

… no anomalous images in a validation set

Signed-off-by: tanemaki <[email protected]>
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. This is a useful addition. Previously the metric would implicitly return the maximum value when all images were normal, but as it shows this was not a robust approach. Explicitly checking these edge cases is much better. I do have 2 suggestions for improvement, see below.

src/anomalib/metrics/threshold/f1_adaptive_threshold.py Outdated Show resolved Hide resolved
tests/unit/metrics/test_adaptive_threshold.py Show resolved Hide resolved
…either normal or anomalous.

* Add an explicit check in the metric implementation for the case where all images are anomalous.

Signed-off-by: tanemaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: F1AdaptiveThreshold incorrectly selects minimum value when no anomalous images are in validation set
2 participants