-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicated size parameter value in ExportableCenterCrop #2203
Open
CarlosNacher
wants to merge
5
commits into
openvinotoolkit:main
Choose a base branch
from
CarlosNacher:fix/exportable_center_crop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix duplicated size parameter value in ExportableCenterCrop #2203
CarlosNacher
wants to merge
5
commits into
openvinotoolkit:main
from
CarlosNacher:fix/exportable_center_crop
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ined in the original torchvision CenterCrop transform
samet-akcay
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, @CarlosNacher!
samet-akcay
reviewed
Aug 22, 2024
samet-akcay
reviewed
Aug 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2203 +/- ##
==========================================
+ Coverage 80.79% 80.81% +0.02%
==========================================
Files 248 248
Lines 10859 10860 +1
==========================================
+ Hits 8773 8776 +3
+ Misses 2086 2084 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
When you export an anomalib's model that have the
CenterCrop
transform in it (torchvision.transforms.v2.CenterCrop
), anomalib automatically replaces thatCenterCrop
transform withExportableCenterCrop
for ONNX compatibility reasons:Okay, but when you try to use that model within an
TorchInferencer
, for example, you will get this error when trying the.predict()
method:And the reason is that the
ExportableCenterCrop
transform checks wether thesize
parameter is a tuple, and if not, repeats the parameter twice in a list. But, normally, thesize
parameter of torchvision CenterCrop is internally represented as alist
and not as atuple
.The proposed solution just changes that line of code (
isinstance
comprobation) to pass either with a tuple or a list (Sequence
type object, as typed in original torchvision CenterCrop transform ).✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.