Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor base classes #2164

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

samet-akcay
Copy link
Contributor

📝 Description

This PR refactors base classes.

  • Rename AnomalyModule to AnomalibModule
  • Remove Base prefix and suffix from the base classes.

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@samet-akcay samet-akcay removed the request for review from paularamo July 2, 2024 09:05
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 92.40506% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.81%. Comparing base (9582b1d) to head (502b627).
Report is 1 commits behind head on main.

Files Patch % Lines
src/anomalib/data/depth/mvtec_3d.py 33.33% 2 Missing ⚠️
src/anomalib/utils/visualization/metrics.py 50.00% 2 Missing ⚠️
src/anomalib/utils/warning.py 75.00% 2 Missing ⚠️
src/anomalib/callbacks/tiler_configuration.py 50.00% 1 Missing ⚠️
src/anomalib/cli/install.py 0.00% 1 Missing ⚠️
src/anomalib/data/depth/folder_3d.py 50.00% 1 Missing ⚠️
src/anomalib/data/image/folder.py 50.00% 1 Missing ⚠️
src/anomalib/data/image/kolektor.py 50.00% 1 Missing ⚠️
src/anomalib/data/image/mvtec.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2164      +/-   ##
==========================================
+ Coverage   80.78%   80.81%   +0.03%     
==========================================
  Files         248      250       +2     
  Lines       10859    10879      +20     
==========================================
+ Hits         8772     8792      +20     
  Misses       2087     2087              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwinvaidya17
Copy link
Collaborator

If I understood correctly, CLI will show AnomalyModule as one of the available models as it is a subclass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants