-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor base classes #2164
Open
samet-akcay
wants to merge
20
commits into
openvinotoolkit:main
Choose a base branch
from
samet-akcay:refactor/rename-base-classes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor base classes #2164
samet-akcay
wants to merge
20
commits into
openvinotoolkit:main
from
samet-akcay:refactor/rename-base-classes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it#2082) remove pkg_resources imports and use packaging instead Co-authored-by: Samet Akcay <[email protected]>
…it#2082) remove pkg_resources imports and use packaging instead Co-authored-by: Samet Akcay <[email protected]>
…otoolkit#2172) Fix requirement parsing issue, and pre-commit
…nto refactor/rename-base-classes
9 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2164 +/- ##
==========================================
+ Coverage 80.78% 80.81% +0.03%
==========================================
Files 248 250 +2
Lines 10859 10879 +20
==========================================
+ Hits 8772 8792 +20
Misses 2087 2087 ☔ View full report in Codecov by Sentry. |
ashwinvaidya17
approved these changes
Aug 5, 2024
If I understood correctly, CLI will show |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR refactors base classes.
AnomalyModule
toAnomalibModule
Base
prefix and suffix from the base classes.✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.