Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasability of the CLI tool should be gated to specific engineers #88

Closed
jakedoublev opened this issue Apr 3, 2024 · 1 comment · Fixed by #178
Closed

Releasability of the CLI tool should be gated to specific engineers #88

jakedoublev opened this issue Apr 3, 2024 · 1 comment · Fixed by #178
Assignees

Comments

@jakedoublev
Copy link
Contributor

Background

We need an access control list to be validated before the release action will run, or any OpenTDF developer could trigger a release of the CLI. See example: https://github.com/virtru-corp/.github/blob/36434ecc9bd5338987b386d7d4c75e7d1b148ba9/virtru-actions/security-actions/check-release-permissions/action.yaml#L12

Acceptance Criteria

  1. a release-acl.yaml file is added in .github with core team members added to the list
  2. the release github action reads in that list and validates that the requester of the run is in that list
  3. if they're not in the list, the action should fail
@jakedoublev
Copy link
Contributor Author

Closed by #178

@jrschumacher jrschumacher linked a pull request Jun 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants