Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter content referenced on the Composition or IG using the _lastUpdated during download #3580

Open
3 tasks
dubdabasoduba opened this issue Oct 28, 2024 · 2 comments
Labels
App Configuration Discussion This is an open discussion that may or may not lead to actionable points Enhancement New feature or request Remote Sync All issues related to syncing data from or to the FHIR server

Comments

@dubdabasoduba
Copy link
Member

Describe the feature request.

  • Currently, the configurations are re-downloaded every time a user logs in with their username and password. While this ensures we fetch updated configurations, it also results in re-downloading content that hasn’t changed, impacting sync time during subsequent syncs.
  • This ticket aims to introduce a lastConfigSync timestamp, which will work alongside the _lastUpdated property on FHIR resources.
    • The lastConfigSync timestamp will have the following characteristics:
    • It will be updated each time the content download is completed successfully.
    • When available, it will be included in subsequent content requests after login.
    • It will be stored in the application’s shared preferences.

Acceptance criteria

  • Always save the lastConfigSync timestamp everytime the configs are complete sync successfully
  • Always attach the lastConfigSync to requests for content referenced on the Composition or IG
  • Correctly store the lastConfigSync on the application share preferences

Implementation plan (For Engineers)
The plan for implementing the solution e.g. via a description or a check list for the various ordered tasks that will need to be completed.
i.e. Describe how you intend to solve the problem

@dubdabasoduba dubdabasoduba added Enhancement New feature or request Remote Sync All issues related to syncing data from or to the FHIR server Discussion This is an open discussion that may or may not lead to actionable points App Configuration labels Oct 28, 2024
@dubdabasoduba
Copy link
Member Author

@ellykits @pld please review this

@pld
Copy link
Member

pld commented Nov 15, 2024

One issue is how to set lastConfigSync, pretty sure we'd need to set this with a time that is provided by the remote server, since I believe that is also where the _lastUpdated is set.

Is there a way that the current server time is already being set back? It might be somewhat cludgy to add that as a returned value from the remote server.

An alternative approach would be to take the largest timestamp in _lastUpdated from the synced resources and use that as the lastConfigSync timestamp. Then we'd make sure we are using the same timezone/etc the server is. If we use this approach we'd have to make sure we use a strict > comparison, as opposed to a >= comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Discussion This is an open discussion that may or may not lead to actionable points Enhancement New feature or request Remote Sync All issues related to syncing data from or to the FHIR server
Projects
None yet
Development

No branches or pull requests

2 participants