Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[results figure] figure overflow #145

Open
rcannood opened this issue Mar 8, 2023 · 4 comments
Open

[results figure] figure overflow #145

rcannood opened this issue Mar 8, 2023 · 4 comments

Comments

@rcannood
Copy link
Member

rcannood commented Mar 8, 2023

          Well, the problem with overflow is this:
  1. funkyheatmap-js renders its dimensions based on the content (so in this case because of long method names the content is wider than available space)
  2. the cell rendering css does not have (currently) any overflow handling

I see 2 ways to deal with this:

  1. add overflow-x: auto to cell css, then figure will stay the same, but will display cropped, available for scrolling
  2. make funkyheatmap scale to certain width, or be constrained by it, and pass this as a parameter (it does not know its parent's width when rendering—ojs ways)
  3. shorten method names (and/or add code to shorten method names automatically)

what do y'all think?

Originally posted by @mxposed in openproblems-bio/website-experimental#76 (comment)

@rcannood rcannood changed the title [results figure] [results figure] figure overflow Mar 8, 2023
@rcannood
Copy link
Member Author

rcannood commented Mar 8, 2023

shorten method names (and/or add code to shorten method names automatically

This is only a temporary solution as more metrics and more datasets will result in the same problem :)

@mxposed
Copy link
Contributor

mxposed commented Mar 8, 2023

I wonder why did you remove column: page from results figure? Was it ugly for non-overflowing figures?

@rcannood
Copy link
Member Author

rcannood commented Mar 8, 2023

Yes but it also accentuates the highlights the issue more :)

@mxposed
Copy link
Contributor

mxposed commented Mar 8, 2023

Basic fix with overflow-x in openproblems-bio/website-experimental@2af3128

Result here:
https://6409081f065ae51749b0d5da--openproblems-experimental.netlify.app/results/batch_integration_feature/

// not sure why the commit didn't trigger the build

@rcannood rcannood transferred this issue from openproblems-bio/website-experimental Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants