Add more information to benchmarks (method, metric and general info) #365
+1,376
−1,842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rcannood
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Great work!
Some minor comments:
missing data shows up as character(0)
If certain data is missing it shows up as character(0). I agree that the some data should always be available, but just on the off-chance that it isn't, it wouldn't be bad to add a check.
Use nicer labels
Use capitalisation and fewer abbreviations. It'd be better to write Repository and Issues instead of repo and issues. The same applies for dataset, method and metric info: docs → Documentation, source → Repository, implementation → Source code, container → Container.
Dataset tags
I like the tags for methods and metrics. Can we do something similar for datasets as well?
Certain references show up as [@]
This might be related to the reference being a bibtex entry?
…m/openproblems-bio/website into feature/no-ref/add-info-to-method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
perturbation_predictionresults with info added from Update reporting components to include all links openproblems#915preview
Related issues
Closes openproblems-bio/task_perturbation_prediction#83
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Preview succeeds and looks good!