Add support for new signature algorithms

[0xturboblitz]

It's crucial for proof of passport to support more signature algorithms. See the map here for which country uses which. Here there are in order of priority.

Signature algorithm	Mock passport data	Register circuit	DSC circuit	Implemented in app	Assigned
rsa sha1	✅	✅	✅	✅
rsa sha256	✅	✅	✅	✅
rsa sha512
rsassaPss sha256	✅	🚧	🚧
ecdsa sha1	🚧	✅
ecdsa sha256	🚧	✅
ecdsa sha384	✅
ecdsa sha512	🚧

They are all based on the same primitives (RSA, ECDSA and SHA) that all have implementations in circom.

With the new circuit design we shipped, adding support for new signature algorithms can be done easily by copying the passport verifier circuit and modifying it.

Hash function circuits here

If you try your hands at those, please include typescript tests for them.

[puneeth072003]

I'd like to take up this issue.

[remicolin]

Hi @puneeth072003 you can work on this, have you experience building circom circuits?
You can't take the whole issue but you can start by working on one of the 3 signature/hash algorithm.

[RajeshRk18]

Can I take up this issue? I've experience contributing to PLUME with circom. So, I'll be able to implement all 3 signature schemes

[0xturboblitz]

Hi @RajeshRk18, yes go for it
If you have questions you can dm us at @FlorentTavernier or @colinremi on telegram

[remicolin]

hi @RajeshRk18
do you have any updates to share with us?
We will assign the rsa-pss part to the person currently working on mgf1.

[RajeshRk18]

@remicolin I am on it! Started working on rsapss already. Will make a pr soon

[RajeshRk18]

RsassaPss is in wip.

[RajeshRk18]

@remicolin Also rsassaPss requires MGF. So, #115 needs to be merged

[remicolin]

@RajeshRk18 Please focus on SHA1 and ECDSA for the moment, they require already a good amount of work.

[0xturboblitz]

Just added the mock passport data for rsassaPss here: https://github.com/zk-passport/proof-of-passport/blob/57ec1c3407ea1f66f348636a68e0d1c6cf914c65/common/src/utils/mockPassportData.ts#L105

If anyone wants to, you can now try doing the full implementation for rsassaPss using #115

[RajeshRk18]

@0xturboblitz why I was unassigned? I am almost done

[seshanthS]

Hello, Shall I take sha1WithRSAEncryption

[0xturboblitz]

Assigning to @seshanthS as @RajeshRk18's sha1 pr is mostly copy-paste and does not compile

[0xVikasRushi]

Hello @remicolin @0xturboblitz 👋

I was thinking to implement ECDSA with sha1.

Please let me know if i can take up the ecdsa-with-SHA1

[0xturboblitz]

please do @0xVikasRushi

[remicolin]

@0xVikasRushi can you give your telegram @?

[0xVikasRushi]

@0xVikasRushi can you give your telegram @?

@Rushi0578