7038838: Unspecified NPE in java.net.IDN methods

[jaikiran]

Can I please get a review of this doc-only changes which specifies the methods on java.net.IDN to throw NullPointerException when any argument is null?

This addresses https://bugs.openjdk.org/browse/JDK-7038838. As noted in that issue, the current implementation of these methods already throw a NullPointerException for any null argument. This change now updates the specification to match the current implementation.

A new jtreg test has been added to verify this behaviour. Note that there already was a test/jdk/java/net/Socket/IDNTest.java test but looking what that test does, the history of that test and the location of that test in java/net/Socket directory made me believe that it's not meant for testing the java.net.IDN class. That's why I created this new test class in test/jdk/java/net/ directory.

I'll draft a CSR for this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8345260 to be approved

Issues

• JDK-7038838: Unspecified NPE in java.net.IDN methods (Bug - P4)
• JDK-8345260: Unspecified NPE in java.net.IDN methods (CSR)

Reviewers

• Chen Liang (@liach - Reviewer)
• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22463/head:pull/22463
$ git checkout pull/22463

Update a local copy of the PR:
$ git checkout pull/22463
$ git pull https://git.openjdk.org/jdk.git pull/22463/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22463

View PR using the GUI difftool:
$ git pr show -t 22463

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22463.diff

Using Webrev

Link to Webrev Comment

[jaikiran]

/csr needed

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@jaikiran has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@jaikiran please create a CSR request for issue JDK-7038838 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[liach]

Note this patch is doc-only and test-only, thus this may be backported to JDK 24 when it enters RDP 1. Looks good, the 4 methods seem to already throw NPE in isRootLabel.

[mlbridge]

Webrevs

• 00: Full (f1605332)