Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345178: RISC-V: Add gtests for narrow cmpxchg #22445

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

robehn
Copy link
Contributor

@robehn robehn commented Nov 28, 2024

Hi, please consider.

This adds tests of aligned narrow cmpxchg.

Note: Google Test filter = *RiscV*
[==========] Running 5 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 5 tests from RiscV
...
[ RUN      ] RiscV.cmpxchg_int16_lr_sc_vm
[       OK ] RiscV.cmpxchg_int16_lr_sc_vm (2 ms)
[ RUN      ] RiscV.cmpxchg_int8_lr_sc_vm
[       OK ] RiscV.cmpxchg_int8_lr_sc_vm (1 ms)
[ RUN      ] RiscV.cmpxchg_int16_maybe_zacas_vm
[       OK ] RiscV.cmpxchg_int16_maybe_zacas_vm (1 ms)
[ RUN      ] RiscV.cmpxchg_int8_maybe_zacas_vm
[       OK ] RiscV.cmpxchg_int8_maybe_zacas_vm (1 ms)
[----------] 5 tests from RiscV (20831 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 1 test suite ran. (20834 ms total)
[  PASSED  ] 5 tests.

Executed with -XX:+UnlockExperimentalVMOptions -XX:+UseZacas

Thanks, Robbin


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345178: RISC-V: Add gtests for narrow cmpxchg (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22445/head:pull/22445
$ git checkout pull/22445

Update a local copy of the PR:
$ git checkout pull/22445
$ git pull https://git.openjdk.org/jdk.git pull/22445/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22445

View PR using the GUI difftool:
$ git pr show -t 22445

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22445.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2024

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 28, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 28, 2024
@openjdk
Copy link

openjdk bot commented Nov 28, 2024

@robehn To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@robehn
Copy link
Contributor Author

robehn commented Nov 28, 2024

/label add hotspot

@openjdk
Copy link

openjdk bot commented Nov 28, 2024

@robehn
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 28, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant