Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .pre-commit-config.yaml #1040

Merged
merged 5 commits into from
Aug 19, 2021
Merged

Add .pre-commit-config.yaml #1040

merged 5 commits into from
Aug 19, 2021

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Aug 9, 2021

Implements a part of #1039

  • Update developer docs

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Attention: Patch coverage is 54.16667% with 33 lines in your changes missing coverage. Please review.

Project coverage is 86.86%. Comparing base (e70c266) to head (0c3457b).
Report is 106 commits behind head on master.

Additional details and impacted files

@mattwthompson mattwthompson mentioned this pull request Aug 17, 2021
2 tasks
@mattwthompson
Copy link
Member Author

Taking this comment #1022 (comment) and a general support elsewhere as approval.

I had already added the bot while working on that PR, so it'll be used to see if this passes.

@mattwthompson
Copy link
Member Author

In principle this replaces .github/workflows/lint.yaml but I'll leave that be for now in case one catches something the other misses / in order to gain some trust.

@mattwthompson mattwthompson merged commit f417161 into master Aug 19, 2021
@mattwthompson mattwthompson deleted the add-pre-commit branch August 19, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant