You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Combining force fields has behavior consequences which are potentially significant and often result in worse performance. Combining force fields, however, is part of the specification and currently supported in de-serialization, so I don't think it's reasonable to claim this behavior out to be unsupported.
The text was updated successfully, but these errors were encountered:
Agree that this would be great, and with your specific proposal to add a combine method. I'd be happy to take a PR for this, and we could probably refactor the ForceField initializer to use this code path when multiple sources are given as input as well.
Is your feature request related to a problem? Please describe.
I frequently wish to combine force fields, like Sage with a different water model. This works fine when loading from disk:
However, if I'm in the middle of a workflow and have already loaded them up into memory, there's no straightforward way to combine
ForceFields
.Describe the solution you'd like
It'd be nice to be able to do something like
Parameter ordering, parameter section compatibility, etc. should follow the existing behavior.
Describe alternatives you've considered
I can handle this with an extra trip to disk, but this is slow and I'd argue should not be necessary.
Additional context
Combining force fields has behavior consequences which are potentially significant and often result in worse performance. Combining force fields, however, is part of the specification and currently supported in de-serialization, so I don't think it's reasonable to claim this behavior out to be unsupported.
The text was updated successfully, but these errors were encountered: