-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove history, core contributor status, and people.yaml #251
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 89.71% 89.33% -0.39%
==========================================
Files 73 73
Lines 4327 4152 -175
Branches 452 429 -23
==========================================
- Hits 3882 3709 -173
+ Misses 410 409 -1
+ Partials 35 34 -1
☔ View full report in Codecov by Sentry. |
openedx/openedx-webhooks#251 removes people.yaml from the OSPR bot, so we no longer need to validate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a little hesitant to remove the core_committer PR comment since I think there is a version of that which could be useful but given that we'd have to do some work in SF to start tracking that info again, I don't think it's useful to keep for now. We don't have a plan to track that data there any time soon since it adds a bunch of on-going overhead.
One option we could explore: keep people.yaml specifically for the core contributor status. It works now, and doesn't need to be updated that often. |
OK, as discussed in Slack, we aren't going to keep people.yaml, which has a more complicated schema than we need anyway. I don't know when we might get CC data from Salesforce, but when we do, we can put back some parts of this code. It feels a little odd to remove it knowing that we might want it back in the future, but we know where it is and we can come back to get it. |
openedx/openedx-webhooks#251 removes people.yaml from the OSPR bot, so we no longer need to validate it.
This removes a lot...