Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove history, core contributor status, and people.yaml #251

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Conversation

nedbat
Copy link
Contributor

@nedbat nedbat commented Aug 8, 2023

This removes a lot...

@nedbat nedbat requested a review from feanil August 8, 2023 17:25
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.39% ⚠️

Comparison is base (a6490a3) 89.71% compared to head (7c2499e) 89.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
- Coverage   89.71%   89.33%   -0.39%     
==========================================
  Files          73       73              
  Lines        4327     4152     -175     
  Branches      452      429      -23     
==========================================
- Hits         3882     3709     -173     
+ Misses        410      409       -1     
+ Partials       35       34       -1     
Files Changed Coverage Δ
openedx_webhooks/bot_comments.py 100.00% <ø> (ø)
openedx_webhooks/labels.py 100.00% <ø> (ø)
openedx_webhooks/lib/webhooks_data/models.py 96.49% <ø> (ø)
openedx_webhooks/tasks/pr_tracking.py 97.32% <ø> (-0.06%) ⬇️
tests/test_pull_request_closed.py 100.00% <ø> (ø)
openedx_webhooks/info.py 98.60% <100.00%> (+0.75%) ⬆️
tests/test_data.py 100.00% <100.00%> (ø)
tests/test_info.py 100.00% <100.00%> (ø)
tests/test_pull_request_opened.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nedbat added a commit to openedx/openedx-webhooks-data-schema that referenced this pull request Aug 9, 2023
openedx/openedx-webhooks#251 removes people.yaml
from the OSPR bot, so we no longer need to validate it.
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little hesitant to remove the core_committer PR comment since I think there is a version of that which could be useful but given that we'd have to do some work in SF to start tracking that info again, I don't think it's useful to keep for now. We don't have a plan to track that data there any time soon since it adds a bunch of on-going overhead.

@nedbat
Copy link
Contributor Author

nedbat commented Aug 10, 2023

One option we could explore: keep people.yaml specifically for the core contributor status. It works now, and doesn't need to be updated that often.

@nedbat
Copy link
Contributor Author

nedbat commented Aug 11, 2023

OK, as discussed in Slack, we aren't going to keep people.yaml, which has a more complicated schema than we need anyway. I don't know when we might get CC data from Salesforce, but when we do, we can put back some parts of this code. It feels a little odd to remove it knowing that we might want it back in the future, but we know where it is and we can come back to get it.

@nedbat nedbat merged commit b3fa2a6 into master Aug 11, 2023
4 checks passed
@nedbat nedbat deleted the nedbat/no-cc branch August 11, 2023 19:47
nedbat added a commit to openedx/openedx-webhooks-data-schema that referenced this pull request Aug 14, 2023
openedx/openedx-webhooks#251 removes people.yaml
from the OSPR bot, so we no longer need to validate it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants