New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log picture removal link generation error #2355

Open

rapotek opened this issue Jun 1, 2022 · 0 comments

Labels

Component CacheLog Priority Medium Type Defect

Contributor

rapotek commented Jun 1, 2022 •

edited

Loading

There is an error in

opencaching-pl/getLogEntries.php

Line 308 in 6ebc32d

    
           if ($loggedUser && ( $pic_record['user_id'] == $loggedUser || $loggedUser->hasOcTeamRole())) {

resulting in the user who added a picture to his own log entry has no link to remove the picture.

This line should be f.ex.:
if ($loggedUser && ( $pic_record['user_id'] == $loggedUser->getUserId() || $loggedUser->hasOcTeamRole())) {

BTW: In future, this page really needs refactoring and picture removal should be done through REST API just like log removal.

The text was updated successfully, but these errors were encountered:

deg-pl added Priority Medium Type Defect Component CacheLog labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment