Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Analytics doesn't work #2287

Open
deg-pl opened this issue May 27, 2021 · 2 comments
Open

Google Analytics doesn't work #2287

deg-pl opened this issue May 27, 2021 · 2 comments
Labels
Component Core General Discussion Priority Medium Type Defect

Comments

@deg-pl
Copy link
Member

deg-pl commented May 27, 2021

From (about) 1 april 2021 Google Analytics doesn't work on OC pages (I've checked OC PL and OC UK):
image
@rapotek
Copy link
Contributor

rapotek commented May 28, 2021

It looks like there should be a line $GLOBALS['googleAnalytics_key'] = $googleAnalytics_key; added to /src/Models/ApplicationContainer.php, private static function loadLegacyConfig() method, or something like that.

@deg-pl
Copy link
Member Author

deg-pl commented Jun 24, 2021

I think we should disable GoogleAnalytics.
We should have user consent to use GA cookies. So we have two solutions:

  • disable GA
  • refactor GA - every user should consent to use GA cookies. It should be informed consent - DISABLED by default!
    We should ask user to use cookies BEFORE we use cookies for this user.

We should not use GA as is in our code.
(Use private mode of your browser and see google.com - they have good cookie consent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component Core General Discussion Priority Medium Type Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deg-pl @rapotek