Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible change to install_package function #65

Open
giovcandido opened this issue Aug 20, 2021 · 3 comments
Open

Possible change to install_package function #65

giovcandido opened this issue Aug 20, 2021 · 3 comments

Comments

@giovcandido
Copy link
Contributor

One thing that could be interesting is to make the function install_package return a boolean value. When the installation is canceled by the user (by pressing 'n' instead of 'y' or enter), you can return without asking to keep the repo. If you guys think it is interesting enough, I can help the solution.

@asdil12
Copy link
Member

asdil12 commented Aug 20, 2021

One one side that could be faster in some situations but on the other side a user could want to remove the repo when he aborted the installation. So I would rather keep it.

@giovcandido
Copy link
Contributor Author

giovcandido commented Aug 20, 2021

Thinking this way, it makes sense. I made the suggestion because I thought that the default behavior when a user canceled the installation was not to keep the repo. If that was the case, we would have to check if repo is already stored as a source before creating it again. I mean, if the user has the repo because of a package they installed in the past and he is presented with the option to keep it or not, he may not know that it would affect the updates of existing packages.

@asdil12
Copy link
Member

asdil12 commented Jun 3, 2023

Note that in the meantime we do check if a repo already exists, before creating it, by comparing the url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants