Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for CVEs in Go sources including vendored modules #48

Open
jfkw opened this issue May 14, 2024 · 0 comments
Open

Check for CVEs in Go sources including vendored modules #48

jfkw opened this issue May 14, 2024 · 0 comments
Assignees

Comments

@jfkw
Copy link
Collaborator

jfkw commented May 14, 2024

The tool govulncheck "reports known vulnerabilities that affect Go code". Add a feature to obs-service-go_modules to run govulncheck, checking the application source and vendored modules.

Package govulncheck is already in openSUSE Factory (devel:languages:go/govulncheck).

Feature goals:

  • Report govulncheck output as plaintext in the build log for this initial version.

  • Run govulncheck by default, but do not break the Go application build based on a positive CVE report or other error at this time. A separate feature implemented later to parse JSON output can opt-in to break the build based on the CVE matching certain platform data e.g. GOOS and GOARCH. We need some operating experience with govulncheck, the https://vuln.go.dev/ service reliability and fields available in the output before it will be practical to enable a build-breaking mode.

  • Allow running only the govulncheck step without forcing re-vendoring Go applications which use a populated vendor/ directory committed into the upstream repository. Re-vendoring is normally recommended to ensure consistency, but it should be possible to skip if circumstances require doing so.

  • Soft dependency on govulncheck package, possibly becoming a hard dependency only after package is accepted into all relevant repositories. If the tool is unavailable, report that and exit.

Assigning to myself.

@jfkw jfkw self-assigned this May 14, 2024
@jfkw jfkw changed the title Check for CVEs in Go sources including vendored modules reference Check for CVEs in Go sources including vendored modules May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant