Cannot vendor kubectl-really-get-all

[johanneskastl]

I tried to package this:
https://github.com/vfx1b/kubectl-really-get-all

It does not have a release, hence I tried to use the latest commit 0ffd9ac.

This is the _service file:

<services>
  <service name="obs_scm" mode="manual">
    <param name="url">https://github.com/vfx1b/kubectl-really-get-all</param>
    <param name="scm">git</param>
    <param name="exclude">.git</param>
    <param name="revision">0ffd9ac</param>
    <param name="versionformat">v0.0.1.%cd.%h</param>
    <param name="changesgenerate">enable</param>
  </service>
  <service name="tar" mode="buildtime"/>
  <service name="recompress" mode="buildtime">
    <param name="file">*.tar</param>
    <param name="compression">gz</param>
  </service>
  <service name="go_modules" mode="manual">
    <param name="archive">kubectl-really-get-all-v0.0.1.20230328.0ffd9ac.obscpio</param>
    <param name="basename">kubectl-really-get-all</param>
  </service>
</services>

But it fails, because it cannot find the go.mod:

Already up to date.
0ffd9ac12eb00c41c7c0b6504990ac7c849ef039
INFO:obs-service-go_modules:Running OBS Source Service: obs-service-go_modules
INFO:obs-service-go_modules:Using archive kubectl-really-get-all-v0.0.1.20230328.0ffd9ac.obscpio
INFO:obs-service-go_modules:Extracting kubectl-really-get-all-v0.0.1.20230328.0ffd9ac.obscpio to /tmp/tmp4ogx0ta7
INFO:obs-service-go_modules:Switching to /tmp/tmp4ogx0ta7
ERROR:obs-service-go_modules:File go.mod not found under /tmp/tmp4ogx0ta7/kubectl-really-get-all
Aborting: service call failed:  /usr/lib/obs/service/go_modules --archive kubectl-really-get-all-v0.0.1.20230328.0ffd9ac.obscpio --basename kubectl-really-get-all --outdir /home/Buildservice/Branches/Branch_devel_kubic/kubectl-really-get-all/tmpk9csjfuu.go_modules.service

Any ideas?

[SchoolGuy]

I am having the same problem and the issue here is according to my debugging the service will try and unpack the obscpio with the version. As such the basename is missing the version.

It is very inconsistent that archive is accepting a glob with a regex and basename not:

• Definition of basename:

  obs-service-go_modules/go_modules

  Lines 243 to 247 in 54cd383

  	basename = (
  	args.basename
  	or basename_from_archive(archive)
  	or basename_from_archive_name(archive)
  	)

• Usage that is not fit for a glob:

  obs-service-go_modules/go_modules

  Lines 249 to 251 in 54cd383

  	go_mod_path = sanitize_subdir(
  	tempdir, os.path.join(tempdir, basename, subdir, "go.mod")
  	)