Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Some parts of the code still use Color() instead of MaterialTheme colors, making the theme inconsistent #1692

Open
Shermine237 opened this issue Jul 3, 2024 · 1 comment

Comments

@Shermine237
Copy link
Contributor

Summary:

Some parts of the code still use Color() instead of MaterialTheme colors, making the theme inconsistent.

Steps to reproduce:

Try changing the theme colors in theme.kt or style.xml and you'll see that some parts of the application remain unchanged.

Expected behaviour:

Use MaterialTheme colors for a uniform theme. This makes it easier to change themes.

Observed behaviour:

In some parts of the code, the colors are hard-coded.

Shermine237 added a commit to Shermine237/mobile-wallet that referenced this issue Jul 3, 2024
Shermine237 added a commit to Shermine237/mobile-wallet that referenced this issue Jul 4, 2024
@TanishMoral11
Copy link

Hey @Shermine237 ,
Could you please provide a bit more detail regarding this issue? Specifically, it would be helpful to understand which parts of the code are still using Color() directly instead of MaterialTheme colors. Additionally, if you have any suggestions or preferred solutions for addressing this,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants