stats: calculate the divergence point and corresponding read fractions #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
golobor
commented
Mar 24, 2024
•
golobor
commented
- use finer distance bins, 8 bins per factor of 10
|
@Phlya @agalitsyna - do you want to take a quick look? |
|
now with tests passing. Stats are a mess and a PITA. ;) |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@agalitsyna @Phlya - I do not plan any further changes, could you review it please? |
|
@Phlya @agalitsyna ping :) |
Phlya
approved these changes
Apr 3, 2024
|
Looks good to me! I am assuming you have run it and it actually works :) |
|
Perhaps we could have a test for the convergence point... |
|
@Phlya, I added the test - LLMs FTW! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.