Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow tests reveal data races in RecordBuilderStats #214

Open
jmacd opened this issue Jun 4, 2024 · 0 comments
Open

Arrow tests reveal data races in RecordBuilderStats #214

jmacd opened this issue Jun 4, 2024 · 0 comments

Comments

@jmacd
Copy link
Contributor

jmacd commented Jun 4, 2024

The RecordBuilderStats object uses non-atomic increments for objects that are shared. The reason this is not as simple as using atomic.Int64, for example, is that there is also an HDRHistogram in there.

This is (as far as a I know) the only reason we couldn't enable race detection for all modules in this repository.
@jmacd jmacd changed the title Arrow tests RecordBuilderStats reveal data races Arrow tests reveal data races in RecordBuilderStats Jun 4, 2024
@jmacd jmacd mentioned this issue Jun 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmacd