Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique Title Request #566

Open
akchaudhary6532 opened this issue Sep 27, 2023 · 0 comments
Open

Unique Title Request #566

akchaudhary6532 opened this issue Sep 27, 2023 · 0 comments

Comments

@akchaudhary6532
Copy link

defmodule Admin.Onboarding do
  defmodule ListResponse do
       
  end
end

and

defmodule User.Onboarding do
  defmodule ListResponse do
       
  end
end

Current Behaviour:

We usually define modules like this. which creates duplicates and ends up overriding each other, giving unexpected results. Finding duplicates manually during PR reviews is also a pain.

Issue:

  1. I wasn't aware that the title should always be unique and that we are using module |> Module.split() |> List.last() to create a title. We should add this in the hexdoc.

  2. We should, at compile time raise an error if there are duplicate titles found in the code.

  3. If point 2 is not possible, then we should use the Absolute path as a title to avoid duplicates.

Hi guys, This is my first time raising a ticket in any open-source project so please ignore the lack of structure above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant