You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
defmodule Admin.Onboarding do
defmodule ListResponse do
end
end
and
defmodule User.Onboarding do
defmodule ListResponse do
end
end
Current Behaviour:
We usually define modules like this. which creates duplicates and ends up overriding each other, giving unexpected results. Finding duplicates manually during PR reviews is also a pain.
Issue:
I wasn't aware that the title should always be unique and that we are using module |> Module.split() |> List.last() to create a title. We should add this in the hexdoc.
We should, at compile time raise an error if there are duplicate titles found in the code.
If point 2 is not possible, then we should use the Absolute path as a title to avoid duplicates.
Hi guys, This is my first time raising a ticket in any open-source project so please ignore the lack of structure above.
The text was updated successfully, but these errors were encountered:
Current Behaviour:
We usually define modules like this. which creates duplicates and ends up overriding each other, giving unexpected results. Finding duplicates manually during PR reviews is also a pain.
Issue:
I wasn't aware that the title should always be unique and that we are using
module |> Module.split() |> List.last()
to create a title. We should add this in the hexdoc.We should, at compile time raise an error if there are duplicate titles found in the code.
If point 2 is not possible, then we should use the Absolute path as a title to avoid duplicates.
Hi guys, This is my first time raising a ticket in any open-source project so please ignore the lack of structure above.
The text was updated successfully, but these errors were encountered: