Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nil check for Burner #155

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Add nil check for Burner #155

merged 2 commits into from
Mar 27, 2024

Conversation

joshuahannan
Copy link
Member

@joshuahannan joshuahannan commented Mar 26, 2024

Description

Add check to see if AnyResource is nil before burning it with the Burner


For contributor use:

  • Targeted PR against v2-standard branch
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@joshuahannan joshuahannan changed the base branch from master to v2-standard March 26, 2024 18:59
@joshuahannan joshuahannan added the enhancement New feature or request label Mar 26, 2024
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only note is unrelated - looks like the repo isn't configured for codecov which is an option now that we have Cadence tests. I can get that setup if you like, just lmk

coverage.json Outdated Show resolved Hide resolved
Copy link

@austinkline austinkline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This unfortunately won't handle cases where we have ?? or greater values but that might be better addressed by the cadence team

@joshuahannan
Copy link
Member Author

I think this is fine for now. If we see that double optionals are causing problems in the future, then we can revisit

@joshuahannan joshuahannan merged commit 8453adb into v2-standard Mar 27, 2024
2 checks passed
@joshuahannan joshuahannan deleted the josh/update-burner branch March 27, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants