Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make iterating through delegators in staking contract more efficient #431

Open
joshuahannan opened this issue May 16, 2024 · 0 comments
Open
Assignees
Labels
Feature Feedback good first issue Good for newcomers Performance SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board

Comments

@joshuahannan
Copy link
Member

Issue To Be Solved

There is a lot of code in the staking contract (FlowIDTableStaking) that iterates through a node's delegators and does something. This could be better.

Example

Suggest A Solution

  • Use a utility function that uses an iterator or something like that to cut back on the boilerplate required for iterating through delegators
@joshuahannan joshuahannan added good first issue Good for newcomers Feedback Feature Performance SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board labels May 16, 2024
@joshuahannan joshuahannan moved this to 🧊 Backlog in 🌊 Flow 4D May 16, 2024
@joshuahannan joshuahannan self-assigned this Sep 26, 2024
@joshuahannan joshuahannan moved this from 🧊 Backlog to 🔖 Ready for Pickup in 🌊 Flow 4D Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feedback good first issue Good for newcomers Performance SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board
Projects
Status: 🔖 Ready for Pickup
Development

No branches or pull requests

1 participant