Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Core Contracts to be compatible with Stable Cadence #294

Closed
dsainati1 opened this issue Jul 5, 2022 · 3 comments
Closed

Update Core Contracts to be compatible with Stable Cadence #294

dsainati1 opened this issue Jul 5, 2022 · 3 comments
Assignees
Labels
bug Something isn't working Feedback SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board

Comments

@dsainati1
Copy link
Contributor

Problem

https://github.com/onflow/flow-core-contracts/blob/master/contracts/LockedTokens.cdc#L231

The linked code does not behave the way it appears to; the as? in this line does not actually function as a reference operator. In a future version of Cadence this code will be rejected by the typechecker.

Steps to Reproduce

Typecheck this contract on the master version of Cadence.

@dsainati1 dsainati1 added bug Something isn't working Feedback labels Jul 5, 2022
@joshuahannan joshuahannan self-assigned this Nov 2, 2022
@joshuahannan joshuahannan added the SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board label Nov 2, 2022
@joshuahannan
Copy link
Member

I've made a PR to address stable cadence changes: #319

@joshuahannan joshuahannan changed the title Upcoming version of Cadence will cause a core contract to fail typechecking Update Core Contracts to be compatible with Stable Cadence Aug 23, 2023
@turbolent
Copy link
Member

@joshuahannan I guess this is complete and can be closed?

@joshuahannan
Copy link
Member

yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Feedback SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board
Projects
None yet
Development

No branches or pull requests

3 participants