Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing copy functins to shp&mhp #582

Open
haichangsi opened this issue Oct 16, 2023 · 0 comments
Open

add missing copy functins to shp&mhp #582

haichangsi opened this issue Oct 16, 2023 · 0 comments
Assignees
@haichangsi

Comments

@haichangsi
Copy link
Contributor

Add missing siugnatures, test them, then remove ifdef in below sort code of sort benchmarking.

#ifdef BENCH_SHP
    xhp::copy(local.begin(), local.end(), rng::begin(*a));
#else
    xhp::copy(local, rng::begin(*a));
#endif
@haichangsi haichangsi converted this from a draft issue Oct 16, 2023
@haichangsi haichangsi self-assigned this Oct 16, 2023
@lslusarczyk lslusarczyk moved this to 🏗 In progress in Distributed-Ranges Project Nov 15, 2023
@haichangsi haichangsi linked a pull request Nov 15, 2023 that will close this issue
added new copy signatures for shp and mhp #640
Closed
@lslusarczyk lslusarczyk moved this from 🏗 In progress to 👀 In review in Distributed-Ranges Project Nov 16, 2023
@lslusarczyk lslusarczyk assigned mateuszpn and unassigned mateuszpn Nov 20, 2023
@haichangsi haichangsi assigned mateuszpn and unassigned haichangsi Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haichangsi haichangsi

Labels
None yet
Projects
Distributed-Ranges Project
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added new copy signatures for shp and mhp haichangsi/distributed-ranges
2 participants
@haichangsi @mateuszpn