Change capsules and cylinders to have separate top and bottom radiuses #234
+80
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
physics-shape-tapered-cylinder
branch
from
b7578b8
to
60832d4
Compare
aaronfranke
force-pushed
the
physics-shape-tapered-cylinder
branch
from
60832d4
to
ec0c4db
Compare
aaronfranke
force-pushed
the
physics-shape-tapered-cylinder
branch
from
ec0c4db
to
32ec46d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Let's merge #238 first.
This PR changes the OMI_physics_shape definition of a capsule and cylinder to have
radiusBottomandradiusTopproperties, which matches the KHR_collision_shapes extension. This PR also changes the capsule's height property to refer to the mid height instead of the full height, which also matches KHR_collision_shapes.https://github.com/eoineoineoin/glTF_Physics/blob/master/extensions/2.0/Khronos/KHR_collision_shapes/schema/glTF.KHR_collision_shapes.shape.capsule.schema.json
https://github.com/eoineoineoin/glTF_Physics/blob/master/extensions/2.0/Khronos/KHR_collision_shapes/schema/glTF.KHR_collision_shapes.shape.cylinder.schema.json
I was initially against this since it seemed that no game engine or physics engine supported it, but Jolt added support for both of these things recently, and they are going to be added to Godot Engine soon. Still, these will have to be approximated using convex hulls when being imported into Unity, Unreal Engine, and more.