Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Bug] Order images first to last when arranged as a grid #60

Open
1 task done
NEKolev opened this issue Jun 10, 2024 · 3 comments
Open
1 task done

[Feature/Bug] Order images first to last when arranged as a grid #60

NEKolev opened this issue Jun 10, 2024 · 3 comments
Labels
bug Something isn't working feature New feature or request interface/experience Improvements to user interface and/or user experience

Comments

@NEKolev
Copy link

NEKolev commented Jun 10, 2024

Is there an existing request for this feature?

  • I have searched the existing issues

Is your feature request related to a problem?

Proper arrangement of the coins in the grid. In my opinion, the expected behaviour is for the images to be arranged from top to bottom, from left to right. In other words, the first image - top left, the second image top right, the third bottom left, the fourth bottom right, and so on. At the moment they are arranged exactly the opposite.

butterfly_viewer_97gjzNZvW9.mp4

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Anything else?

No response

@NEKolev NEKolev added the feature New feature or request label Jun 10, 2024
@larsmaxfield larsmaxfield added annoying Something is annoying, but still functioning interface/experience Improvements to user interface and/or user experience labels Jun 11, 2024
@larsmaxfield
Copy link
Contributor

larsmaxfield commented Jun 11, 2024

TL;DR: Good feature (and actually more of a bug), but I likely won't get to it soon.
__

Unfortunately the video you added doesn't play for me:

image

Nevertheless if I understand correctly, this is an issue regarding the order of the images when they are arranged as a grid. Specifically, that the order is not in the order they are added into the Viewer (from first to last), but rather in what seems to be reverse order (from last to first).

I agree that the order should be from first added to last added.

I've actually known of this issue since I started making this app. Unfortunately it is the standard behavior of the tileSubWindows() slot in Qt's QMdiArea. And it's actually worse than reverse order — rather, the tiling (arranging) order changes based on the last image window you've interacted with, but that change only then happens when you resize the Viewer window. So I would classify it as both a feature and a bug.

I remember trying to solve this but giving up. I think because I had then successfully implemented both horizontal and vertical arrangement which both preserve the first-to-last image order.

But now as I write this, perhaps the solution is to simply create my own grid arrangement method which preserves the order. That will be a bit more tricky though, especially when the number of image windows is a prime number above two because one of the windows will need to be bigger.

@larsmaxfield larsmaxfield changed the title [Feature] Proper arrangement of the images in the grid [Feature] Order images first to last when arranged as a grid Jun 11, 2024
@larsmaxfield larsmaxfield added the bug Something isn't working label Jun 11, 2024
@larsmaxfield larsmaxfield changed the title [Feature] Order images first to last when arranged as a grid [Feature/Bug] Order images first to last when arranged as a grid Jun 11, 2024
@NEKolev
Copy link
Author

NEKolev commented Jun 11, 2024

TL;DR: Good feature (and actually more of a bug), but I likely won't get to it soon. __

Unfortunately the video you added doesn't play for me:

image

Nevertheless if I understand correctly, this is an issue regarding the order of the images when they are arranged as a grid. Specifically, that the order is not in the order they are added into the Viewer (from first to last), but rather in what seems to be reverse order (from last to first).

I agree that the order should be from first added to last added.

I've actually known of this issue since I started making this app. Unfortunately it is the standard behavior of the tileSubWindows() slot in Qt's QMdiArea. And it's actually worse than reverse order — rather, the tiling (arranging) order changes based on the last image window you've interacted with, but that change only then happens when you resize the Viewer window. So I would classify it as both a feature and a bug.

I remember trying to solve this but giving up. I think because I had then successfully implemented both horizontal and vertical arrangement which both preserve the first-to-last image order.

But now as I write this, perhaps the solution is to simply create my own grid arrangement method which preserves the order. That will be a bit more tricky though, especially when the number of image windows is a prime number above two because one of the windows will need to be bigger.

Most likely you have an ad blocker or something else that stops the playback. I uploaded the clip here, but either way, the problem is exactly what you described in detail.

@NEKolev NEKolev closed this as completed Jun 11, 2024
@NEKolev NEKolev reopened this Jun 11, 2024
@larsmaxfield
Copy link
Contributor

Most likely you have an ad blocker or something else that stops the playback. I uploaded the clip here, but either way, the problem is exactly what you described in detail.

Thanks for confirming and for adding the alternate video link. Indeed the video issue seems to be coming from my side.

@larsmaxfield larsmaxfield removed the annoying Something is annoying, but still functioning label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature or request interface/experience Improvements to user interface and/or user experience
Projects
None yet
Development

No branches or pull requests

2 participants