Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🙏 Missing licences > CC BY-ND 4.0, CC BY-NC-SA 4.0,CC BY-NC-ND 4.0 #95

Closed
3 tasks done
adriens opened this issue Mar 14, 2023 · 18 comments
Closed
3 tasks done

Comments

@adriens
Copy link
Contributor

adriens commented Mar 14, 2023

❔ Context

I'm currently working on an open data project in New-Caledonia and I need to get some proper licences data.
I found your site very helpful but I'm missing the following ones :

🎫 Related issues

@rufuspollock
Copy link
Member

@adriens good point - would you be up for opening a pull request to fix that?

@adriens
Copy link
Contributor Author

adriens commented Mar 15, 2023

Yup, I could, is the only thing to do is to manually feed the licenses.csv ?

@rufuspollock
Copy link
Member

@adriens you actually just create them as json files in https://github.com/okfn/licenses/tree/master/licenses see e.g. https://github.com/okfn/licenses/blob/master/licenses/CC-BY-4.0.json

Note the NC licenses are all not open (that's why they weren't in here before) -- see e.g. https://blog.okfn.org/2010/06/24/why-share-alike-licenses-are-open-but-non-commercial-ones-arent/ and https://blog.okfn.org/2012/10/04/making-a-real-commons-creative-commons-should-drop-the-non-commercial-and-no-derivatives-licenses/

So if you add them you need to make sure you have "od_conformance": "rejected" -- see e.g. https://github.com/okfn/licenses/blob/master/licenses/ukclickusepsi.json

adriens added a commit to adriens/licenses that referenced this issue Mar 18, 2023
adriens added a commit to adriens/licenses that referenced this issue Mar 18, 2023
adriens added a commit to adriens/licenses that referenced this issue Mar 18, 2023
@adriens
Copy link
Contributor Author

adriens commented Mar 18, 2023

I have created three distincts PRs for an easier review process 🤞

@rufuspollock
Copy link
Member

rufuspollock commented Mar 20, 2023

@adriens thanks!

@mlinksva @Stephen-Gates @ldodds @jwyg @hlainchb would love your thoughts and comments here before merging. I think it makes sense to have these in if properly flagged as "not open".

@hlainchb
Copy link
Contributor

hlainchb commented Mar 20, 2023 via email

@Stephen-Gates
Copy link
Contributor

Agreed

@adriens
Copy link
Contributor Author

adriens commented Mar 20, 2023

😸 🤞

@ldodds
Copy link
Contributor

ldodds commented Mar 20, 2023

Makes sense to me.

@adriens
Copy link
Contributor Author

adriens commented Mar 20, 2023

👐

@rufuspollock
Copy link
Member

FIXED. Have merged the PRs for this. 👍

@adriens
Copy link
Contributor Author

adriens commented Mar 23, 2023

so.... we are all good ❔ 🤩

@adriens
Copy link
Contributor Author

adriens commented Mar 24, 2023

Looks like I cannot find them on the csv 🙏 😅

@adriens
Copy link
Contributor Author

adriens commented Mar 24, 2023

image

@adriens
Copy link
Contributor Author

adriens commented Mar 24, 2023

image

@adriens
Copy link
Contributor Author

adriens commented Mar 24, 2023

image

@mlinksva
Copy link
Contributor

@adriens the CSV file is generated by a script. Fixed various small issues (and one largish--ND is not OD conformant) with the added licenses, ported the script to python 3, ran the script in #100

@adriens
Copy link
Contributor Author

adriens commented Mar 24, 2023

Yup, now everything works out of the box, check this

select * from 
read_csv_auto('https://raw.githubusercontent.com/okfn/licenses/master/licenses.csv')
where
    id like 'CC-BY-ND%' or
    id like 'CC-BY-NC%';

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants