Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to check licenses.csv against datapackage.json #58

Closed
Stephen-Gates opened this issue Jul 18, 2017 · 7 comments · Fixed by #62
Closed

Add test to check licenses.csv against datapackage.json #58

Stephen-Gates opened this issue Jul 18, 2017 · 7 comments · Fixed by #62

Comments

@Stephen-Gates
Copy link
Contributor

Based on http://okfnlabs.org/blog/2016/05/17/automated-data-validation.html

Especially important if constraints are added to schema

@rufuspollock
Copy link
Member

@Stephen-Gates +1 and you can use goodtables.io (or this will soon be integrated into the new release of datahub.io)

@Stephen-Gates
Copy link
Contributor Author

Used goodtables.io for #57

goodtables.io

@Stephen-Gates
Copy link
Contributor Author

@rufuspollock can you set up goodtables.io to test [licenses.csv[(https://raw.githubusercontent.com/okfn/licenses/master/licenses.csv) against datapackage.json and add the badge link to the readme? I don't have rights to use this repo in GoodTables.

@rufuspollock
Copy link
Member

@Stephen-Gates what would it take for you to get able to do that - i'd prefer to sort that than directly fix so that you are empowered on these things in the future.

/cc @mlinksva

@Stephen-Gates
Copy link
Contributor Author

Stephen-Gates commented Nov 7, 2017

@rufuspollock I believe I'd need some level of rights to the repository to register it with GoodTables.io for continuous integration.

Edit: I need to access to add a web hook:
screenshot 2017-11-07 20 48 43

Edit 2: and this issue fixed in goodtables frictionlessdata/goodtables.io#277

@mlinksva
Copy link
Contributor

mlinksva commented Nov 7, 2017

@Stephen-Gates sent you an invite, accept and you should be able to add webhooks to this repo.

@Stephen-Gates
Copy link
Contributor Author

Stephen-Gates commented Nov 7, 2017

Thanks @mlinksva, accepted and will now progress automating validation of csv using good tables.io and add a badge to the readme goodtables.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants