Remove obsolete providers #9629
Conversation
Provider is supported up to 1.20.x Signed-off-by: Sean Hefty <[email protected]>
Provider is supported up to 1.20.x Signed-off-by: Sean Hefty <[email protected]>
Signed-off-by: Sean Hefty <[email protected]>
GNI is supported up to 1.20.x Signed-off-by: Sean Hefty <[email protected]>
j-xiong
force-pushed
the
remove-obsolete-providers
branch
from
a67f447
to
54e7029
Compare
NetworkDirect is now supported by the verbs provider. Signed-off-by: Sean Hefty <[email protected]> Signed-off-by: Jianxin Xiong <[email protected]>
j-xiong
force-pushed
the
remove-obsolete-providers
branch
from
54e7029
to
630d87d
Compare
|
Do you need to bump the version to 2.x? |
|
@shijin-aws I don't think so. The API doesn't change. |
|
Since we agreed that we will use main for 2.x development, and only cut 1.x release on demand. I think we need some way to divide which commits should be only for 2.x and won't be part of 1.x when we cut a 1.x branch release in the future. I thought such obsolete provider removal is part of 2.x? |
|
The proposed changes are classified into three categories: We want to delay the creation of 1.x branch as much as possible. The plan is to do that when patches in category (3) are merged. |
|
Thank you. AWS still needs a 1.21 release for a new feature #9525 that is being development in the current main branch. IIUC what you said it should be still be ok to cut 1.x release from main before the (3) happens? |
|
That's right. |
|
@ofiwg/intel-middleware |
|
Got it
Maria
On Dec 8, 2023, at 1:48 PM, Jianxin Xiong ***@***.******@***.***>> wrote:
@ofiwg/intel-middleware<https://github.com/orgs/ofiwg/teams/intel-middleware>
—
Reply to this email directly, view it on GitHub<#9629 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADAPWTTCLP5OHZX7ZJXKQGTYINVHLAVCNFSM6AAAAABAKGDIXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBXG42TSMBWHE>.
You are receiving this because you are on a team that was mentioned.Message ID: ***@***.***>
|
| --disable-efa | ||
| --disable-gni | ||
| --disable-hook_debug | ||
| --disable-mrail | ||
| --disable-perf | ||
| --disable-psm |
There was a problem hiding this comment.
psm (v1) should have already be removed. so you should be able to remove --disable-psm
|
Why is GNI being removed? |
|
@jswaro The GNI provider is not being actively maintained (the last update was 2 years ago). Please feel free to provide your input here. |
I'll ask around. I don't know if anyone is directly impacted. I haven't received an answer yet. |
No description provided.